diff -ruBbd cacti-0.8.7a/auth_login.php cacti-0.8.7a-patched/auth_login.php --- cacti-0.8.7a/auth_login.php 2007-11-17 13:11:51.000000000 -0500 +++ cacti-0.8.7a-patched/auth_login.php 2008-02-11 20:01:10.000000000 -0500 @@ -51,6 +51,8 @@ } } +$username = sanitize_search_string($username); + /* process login */ $copy_user = false; $user_auth = false; diff -ruBbd cacti-0.8.7a/graph.php cacti-0.8.7a-patched/graph.php --- cacti-0.8.7a/graph.php 2007-11-17 13:11:51.000000000 -0500 +++ cacti-0.8.7a-patched/graph.php 2008-02-11 20:01:10.000000000 -0500 @@ -33,10 +33,15 @@ include("./include/top_graph_header.php"); /* ================= input validation ================= */ -input_validate_input_regex(get_request_var("rra_id"), "^([0-9]+|all)$"); +input_validate_input_regex(get_request_var_request("rra_id"), "^([0-9]+|all)$"); input_validate_input_number(get_request_var("local_graph_id")); +input_validate_input_regex(get_request_var_request("view_type"), "^([a-zA-Z0-9]+)$"); /* ==================================================== */ +if (!isset($_GET['rra_id'])) { + $_GET['rra_id'] = 'all'; +} + if ($_GET["rra_id"] == "all") { $sql_where = " where id is not null"; }else{ diff -ruBbd cacti-0.8.7a/graph_view.php cacti-0.8.7a-patched/graph_view.php --- cacti-0.8.7a/graph_view.php 2007-11-17 13:11:51.000000000 -0500 +++ cacti-0.8.7a-patched/graph_view.php 2008-02-11 20:01:10.000000000 -0500 @@ -34,6 +34,9 @@ input_validate_input_number(get_request_var("tree_id")); input_validate_input_number(get_request_var("leaf_id")); input_validate_input_number(get_request_var("rra_id")); +input_validate_input_regex(get_request_var_request('graph_list'), "^([\,0-9]+)$"); +input_validate_input_regex(get_request_var_request('graph_add'), "^([\,0-9]+)$"); +input_validate_input_regex(get_request_var_request('graph_remove'), "^([\,0-9]+)$"); /* ==================================================== */ if (isset($_GET["hide"])) { @@ -417,7 +420,7 @@